search

DockYard / ember-cart

Shopping cart primitives for Ember
MIT License
53 stars 18 forks source link

Fix isServiceFactory deprecation with Ember 1.13 #21

Closed iancanderson closed 8 years ago

iancanderson commented 8 years ago

Since Ember 1.13, Ember expects that services either extend Ember.Service, or they should set isServiceFactory to true at the class level. Since the Cart service already extends ArrayProxy, this commit reopens the Cart service class to set isServiceFactory to true.

See https://github.com/emberjs/ember.js/pull/11261

I noticed this from a deprecation warning in a 1.13.x ember app that depends on ember-cart.