search

DockYard / ember-in-viewport

Detect if an Ember View or Component is in the viewport @ 60FPS
MIT License
245 stars 91 forks source link

TypeError: Cannot read property 'viewportConfig' of undefined #232

Closed fran-worley closed 4 years ago

fran-worley commented 4 years ago

I suspect this is an issue caused by how we use ember-in-viewportin ember-light-table but @snewcomer any ideas why I'm suddenly getting this error for ember 3.4?

https://travis-ci.org/github/offirgolan/ember-light-table/jobs/671943228#L1453

I've tried dropping ember-in-viewport back down to 3.5.8 (which used to work) and it makes no difference. Any chance you could point me in the right direction?

Gorzas commented 4 years ago

The problem you're facing is in this line. I still don't know why does it fails with ember-light-table.

fran-worley commented 4 years ago

In the interests of progress, we're removing support for Ember 3.4 from the final release of Version 2.x.

snewcomer commented 4 years ago

@fran-worley Can this issue be closed? It may have been lack of support for older versions...

fran-worley commented 4 years ago

I think so - we just had to drop support for ember <3.6