search

DockYard / ember-in-viewport

Detect if an Ember View or Component is in the viewport @ 60FPS
MIT License
245 stars 91 forks source link

Use {{in-viewport}} modifier multiple times on a page only trigger the last one's callback #245

Closed oo6 closed 4 years ago

oo6 commented 4 years ago

Version

3.7.7

Test Case

https://ember-twiddle.com/85422a05c7149e37a3871be3d75a47a9?openFiles=templates.application%5C.hbs%2C

Steps to reproduce

Use {{in-viewport}} modifier multiple times on a page.

Expected Behavior

Every modifier's onEnter will trigger.

Actual Behavior

Only trigger the last one.

MrChocolatine commented 4 years ago

I can also reproduce the issue. Updating to 3.7.7 suddenly breaks one of my test, a onEnter callback being not triggered.

snewcomer commented 4 years ago

3.7.8! Thanks for reporting