search

DockYard / ember-in-viewport

Detect if an Ember View or Component is in the viewport @ 60FPS
MIT License
245 stars 91 forks source link

Upgrade ember-auto-import to v2 #285

Closed SergeAstapov closed 3 years ago

SergeAstapov commented 3 years ago

This is built on top of #283 and has two breaking changes:

  1. It explicitly drops Node.js v10 support in package.json's engine property
  2. Upgrades ember-auto-import to v2.

Per ember-auto-import 1.x to 2.x migration guide:

addons that upgrade to ember-auto-import >= 2 will only work in apps that have ember-auto-import >= 2, so they should do their own semver major releases when they upgrade

There is a bunch of wins (especially performance) for apps that update to e-a-i v2 and e-a-i v2 will be a hard requirement for apps to run Ember v4 (which should not be big deal as apps running v2 should be able to use addons running e-a-i v1, but why not). There is great write up from @buschtoens about this https://twitter.com/buschtoens/status/1449745386571247620

cibernox commented 3 years ago

It looks great! I'm going to merge it. If we're going to bump version because of ember-auto-import it's good that we also drop node 10.

cibernox commented 3 years ago

@SergeAstapov is there anything else you found should be updated before I cut v4?

SergeAstapov commented 3 years ago

@cibernox @snewcomer we should delete now deprecated in-viewport mixin as it's already marked for deprecation for v4.0.0

I'll create PR later today.

snewcomer commented 3 years ago

That sounds great! Lmk if you need any help

SergeAstapov commented 3 years ago

@snewcomer I've done mixin clean up and it appear quite a bunch of tests related to it.

So I'm working on fixing tests and it will take few more days.