Closed vstefanovic97 closed 2 years ago
I found the options passed to the in-viewport modifier were being ignored. Turns out if we run
options
in-viewport
const { onEnter, onExit, ...options } = this.args.named; return options; // it returns { options: {} }
But we need it to return the contents of the options object. You can check this on a simple example
const {...options } = { options: {foo: '42'}}; console.log(options); // logs {options: {…}} // instead we want it to just log {foo: 42}
Turns out this modifier never expected to get options as an argument, sorry for the confusion. I'm closing this PR
I found the
options
passed to thein-viewport
modifier were being ignored. Turns out if we runBut we need it to return the contents of the options object. You can check this on a simple example