search

DockYard / ember-maybe-in-element

Conditionally render content elsewhere using #-in-element on ember apps
MIT License
15 stars 10 forks source link

Breaks In Ember v4 #47

Open knownasilya opened 3 years ago

knownasilya commented 3 years ago

Due to this deprecation:

DEPRECATION: registerPlugin is deprecated, please pass plugins directly via `compile` and/or `precompile`. [deprecation id: template-compiler.registerPlugin]
        at logDeprecationStackTrace (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-source/dist/@ember/debug/lib/deprecate.js:125:1)
        at HANDLERS.<computed> (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-source/dist/@ember/debug/lib/handlers.js:26:1)
        at raiseOnDeprecation (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-source/dist/@ember/debug/lib/deprecate.js:152:1)
        at HANDLERS.<computed> (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-source/dist/@ember/debug/lib/handlers.js:26:1)
        at invoke (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-source/dist/@ember/debug/lib/handlers.js:38:1)
        at deprecate (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-source/dist/@ember/debug/lib/deprecate.js:226:1)
        at Object.registerPlugin (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-source/dist/ember-template-compiler/lib/system/compile-options.js:122:1)
        at Object.registerPlugins (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-maybe-in-element/node_modules/ember-cli-htmlbars/lib/utils.js:142:26)
        at new TemplateCompiler (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-maybe-in-element/node_modules/ember-cli-htmlbars/lib/template-compiler-plugin.js:45:11)
        at Class.transpileTree (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-maybe-in-element/node_modules/ember-cli-htmlbars/lib/ember-addon-main.js:65:12)
        at Object.toTree (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-maybe-in-element/node_modules/ember-cli-htmlbars/lib/ember-addon-main.js:99:23)
        at /Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-cli-preprocess-registry/preprocessors.js:188:26
        at Array.forEach (<anonymous>)
        at processPlugins (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-cli-preprocess-registry/preprocessors.js:186:11)
        at module.exports.preprocessTemplates (/Users/iradchenko/workspace/mapgeo-sync/node_modules/ember-cli-preprocess-registry/preprocessors.js:169:10)
lifeart commented 3 years ago

ember-cli-htmlbars dependency should be updated: emberjs/ember.js#19429 (comment) to >= 5.6.0

works for me: https://github.com/lifeart/ember-ref-bucket/pull/27 (deps update + ember-cli-update)

raido commented 2 years ago

For me deduplication solved it, example with Yarn: npx yarn-deduplicate --packages ember-cli-htmlbars