search

DockYard / ember-route-action-helper

Bubble closure actions in routes
MIT License
329 stars 48 forks source link

Fix #45 Remove getowner-polyfill dependency #46

Closed Frozenfire92 closed 7 years ago

Frozenfire92 commented 7 years ago

issue #45

Frozenfire92 commented 7 years ago

I'm unsure on the best way to make your test suite pass for older versions of ember. Is there a way that you can conditionally include a dependency based on the version of ember used?

rwjblue commented 7 years ago

The deprecation isn't about having the polyfill addon as a dependency, it's deprecating importing it manually as a function (instead of using Ember.getOwner directly).

poteto commented 7 years ago

@rwjblue Happy with the update?

rwjblue commented 7 years ago

Thank you!