search

DockYard / ember-service-worker

A pluggable approach to Service Workers for Ember.js
http://ember-service-worker.com
MIT License
236 stars 63 forks source link

Upgrade broccoli-rollup #138

Closed eshtadc closed 6 years ago

eshtadc commented 6 years ago

Upgrade to recent rollup via broccoli-rollup

eshtadc commented 6 years ago

Need to ensure cache buster values are included per https://github.com/DockYard/ember-service-worker/pull/131#issuecomment-431568080

eshtadc commented 6 years ago

So what I'm seeing is that only the cache value that is used per your configuration stays. So if you are using project-version or the default then you wouldn't see the PROJECT_REVISION constant. I did confirm that if you are using project-revision strategy that the PROJECT_REVISION constant is included in the output. This should be fine. What we don't have is a fallback if the user accidentally enters the revision strategy incorrectly (like I did initially when testing this).

eshtadc commented 6 years ago

Created https://github.com/DockYard/ember-service-worker/pull/140 to address version strategy validation.