DockYard / ember-service-worker

A pluggable approach to Service Workers for Ember.js
http://ember-service-worker.com
MIT License
236 stars 63 forks source link

Holistic approach to fetch settings #144

Open eshtadc opened 5 years ago

eshtadc commented 5 years ago

Most SW plugins make fetch calls and there is a need to enable authorization to be sent. This seems like something that should be configured rather than defaulted, but it applies to many different plugins. Rather than having a configuration per plugin that has the application developer repeat, it may make sense to have some sort of fetch init configuration specified in the the overall service worker addon. In some ways I could also see this as an odd choice from a purist standpoint because it isn't used by the SW addon directly. The original PR that triggered this is https://github.com/DockYard/ember-service-worker-cache-fallback/pull/9

Creating this issue as a place to discuss pros/cons....