search

DockYard / ember-service-worker

A pluggable approach to Service Workers for Ember.js
http://ember-service-worker.com
MIT License
237 stars 62 forks source link

Version 0.7.2 breaks Glimmer.js app #146

Open tschoartschi opened 5 years ago

tschoartschi commented 5 years ago

We used ember-service-worker with our Glimmer.js app and it just worked fine with version v0.6.2 now we tried to upgrade to the newest version which is currently v0.7.2 but this upgrade broke our build. This is due to the fact, that Glimmer.js has not installed ember-cli-babel and therefore the following code breaks:

https://github.com/DockYard/ember-service-worker/blob/5ffad2483808e3a05860b3f00fb731e0fd24c147/lib/service-worker-builder.js#L125

On the other hand adding ember-cli-babel breaks our Glimmer.js build. So I'm not sure how to resolve this issue.

I know that Ember.js is not Glimmer.js and therefore I'm not sure if this is an issue with ember-service-worker or a Glimmer.js issue. Nevertheless it would be great to share as much addons and plugins as possible between Ember.js and Glimmer.js

Just let me know what you think about this issue

tschoartschi commented 5 years ago

@marten-dockyard could someone give me feedback on this issue? If we want to support glimmer.js and if we have a rough idea how to do so, I could try to create a PR 🙂

tschoartschi commented 5 years ago

would be great to get some opinion about this problem. As I said, I could maybe help to make this addon available for glimmer.js

eshtadc commented 5 years ago

Looks like this would have started here: https://github.com/DockYard/ember-service-worker/commit/9d6db8a846c270b641010bdef6a87e14fe7d1d40#diff-61e7a77a0dda836b877cba3567f38581 My understanding is that this choice was made to leverage ember-cli-babel various features to work with targets, polyfills, etc. I must admit that I haven't had a chance to work much with glimmer. I don't see anything immediately in glimmer that prevents the usage of ember-cli-babel. Can you explain your scenario a bit more? Do you have any suggestions for alternate approaches?

tschoartschi commented 5 years ago

@eshtadc thanks for the response :-) if I add ember-cli-babel to our glimmer.js project we can not build it anymore. Maybe it's a bug with the glimmer-application-pipeline. I need to investigate this in more detail maybe I need to open an issue at the glimmer-application-pipeline as well