DockYard / ember-service-worker

A pluggable approach to Service Workers for Ember.js
http://ember-service-worker.com
MIT License
236 stars 62 forks source link

Uncaught ReferenceError: ESW_INLINE_PLACEHOLDER is not defined #99

Closed davidbilling closed 6 years ago

davidbilling commented 6 years ago

When I set registrationStrategy to inline, my test fails with:

"Uncaught ReferenceError: ESW_INLINE_PLACEHOLDER is not defined"

My config:

'ember-service-worker': {
  enabled: true,
  versionStrategy: 'every-build',
  registrationStrategy: 'inline'
},

Ember-cli 2.17.1

RobbieTheWagner commented 6 years ago

I also randomly just started seeing this.

davidbilling commented 6 years ago

Update @rwwagner90 I have updated to Ember-cli 3.0.0 and ember-service-worker 0.6.11 and it is still there. My quickfix is to comment out registrationStrategy when testing and uncomment on release.

RobbieTheWagner commented 6 years ago

@davidbilling it's odd I never saw this before though. I made some changes to ember-service-worker-prember and all the sudden got this.

RobbieTheWagner commented 6 years ago

@martndemus any ideas on this? I'm still unable to use inline.

davidbilling commented 6 years ago

@cyk @martndemus I see this fix for this is merged and alot of other things, will there be a new release soon?

ghost commented 6 years ago

Released 0.6.13

davidbilling commented 6 years ago

@marten-dockyard Big thanks!