DockYard / eslint-plugin-ember-suave

DockYard's ESLint plugin for Ember apps
MIT License
53 stars 10 forks source link

Error: Failed to load plugin ember-suave/recommended: Cannot find module 'eslint-plugin-ember-suave/recommended' #53

Closed edouard-lopez closed 6 years ago

edouard-lopez commented 7 years ago

Config

I use ember-suave through my own eslint-config-mine/ember:

module.exports = {
  env: {
    browser: true
  },
  extends: ['./base.js'],
  plugins: ['ember-suave/base']
};

Output

Trying to use the plugin ember-suave/base or ember-suave/recommended in my config throw this error:

$ ember test                                                                                                                                                                                                                         [2/4034]
Could not start watchman
Visit https://ember-cli.com/user-guide/#watchman for more info.
⠸ Building'instrument' is imported from external module 'ember-data/-debug' but never used
cleaning up...
Build failed.
The Broccoli Plugin: [SimpleConcatConcat] failed with:
Error: Failed to load plugin ember-suave/recommended: Cannot find module 'eslint-plugin-ember-suave/recommended'
Referenced from: /data/projects/employee-app-front/.eslintrc.js
    at Function.Module._resolveFilename (module.js:489:15)
    at Function.resolve (internal/module.js:18:19)
    at Object.load (/data/projects/employee-app-front/node_modules/eslint/lib/config/plugins.js:134:29)
    at Array.forEach (<anonymous>)
    at Object.loadAll (/data/projects/employee-app-front/node_modules/eslint/lib/config/plugins.js:162:21)
    at load (/data/projects/employee-app-front/node_modules/eslint/lib/config/config-file.js:541:21)
    at configExtends.reduceRight (/data/projects/employee-app-front/node_modules/eslint/lib/config/config-file.js:424:36)
    at Array.reduceRight (<anonymous>)
    at applyExtends (/data/projects/employee-app-front/node_modules/eslint/lib/config/config-file.js:408:28)
    at Object.load (/data/projects/employee-app-front/node_modules/eslint/lib/config/config-file.js:566:22)

The broccoli plugin was instantiated at:
    at Concat.Plugin (/data/projects/employee-app-front/node_modules/broccoli-plugin/index.js:7:31)
    at new Concat (/data/projects/employee-app-front/node_modules/broccoli-concat/concat.js:38:10)
    at module.exports (/data/projects/employee-app-front/node_modules/broccoli-concat/index.js:26:10)
    at Function.EslintValidationFilter.create (/data/projects/employee-app-front/node_modules/broccoli-lint-eslint/lib/index.js:215:10)
    at Class.lintTree (/data/projects/employee-app-front/node_modules/ember-cli-eslint/index.js:44:19)
    at project.addons.reduce (/data/projects/employee-app-front/node_modules/ember-cli/lib/models/addon.js:406:26)
    at Array.reduce (<anonymous>)
    at Class._eachProjectAddonInvoke (/data/projects/employee-app-front/node_modules/ember-cli/lib/models/addon.js:403:32)
    at Class._lintMirageTree (/data/projects/employee-app-front/node_modules/ember-cli-mirage/index.js:82:32)
    at Class.treeForApp (/data/projects/employee-app-front/node_modules/ember-cli-mirage/index.js:109:23)

same with base

Error: Failed to load plugin ember-suave/base: Cannot find module 'eslint-plugin-ember-suave/base'

Question

What's the matter here? If I use plugins: ['ember-suave'] I have no such working.

Serabe commented 6 years ago

Really sorry for the late response. Is this still an issue? Can you provide a repo or a minimal reproduction so we can debug it?

Thanks!

edouard-lopez commented 6 years ago

Current config use extends:

extends: [
    ...
    'plugin:ember-suave/recommended'
]