search

DockYard / eslint-plugin-ember-suave

DockYard's ESLint plugin for Ember apps
MIT License
53 stars 10 forks source link

new modules api #54

Closed asantos00 closed 5 years ago

asantos00 commented 6 years ago

Hi!

Guys, do we plan to do something like this https://github.com/ember-cli/eslint-plugin-ember/issues/86 ? As the new version of ember recommends this import syntax, I think it makes sense... (even if it is not activated on the default configuration)

Thanks

brzpegasus commented 6 years ago

Absolutely! 👍

asantos00 commented 6 years ago

It is already done in another awesome ember lint plugin. https://github.com/ember-cli/eslint-plugin-ember.

Is there a way we can add the rule without just copying it? If there is none, I will give credits to them and just add this rule here, otherwise I'm more than happy to follow your suggestions

Rule code: https://github.com/ember-cli/eslint-plugin-ember/blob/master/lib/rules/new-module-imports.js

brzpegasus commented 6 years ago

@asantos00 Yup, the intention was not to duplicate the rule, but to reference it in our default config.

asantos00 commented 6 years ago

Dumb question: Can we just add the new-module-imports rule at our default config without having the rule implemented?

Since we are not extending https://github.com/ember-cli/eslint-plugin-ember I don't know how to do it :/