search

DockYard / openid_connect

MIT License
65 stars 42 forks source link

Support for self-issued #26

Open CrowdHailer opened 4 years ago

CrowdHailer commented 4 years ago

https://openid.net/specs/openid-connect-core-1_0.html#SelfIssued

I can't find any documentation around how to do self issued identity providers. I don't think it works by just setting the correct issuer. Is there a setting or is it unsupported

bcardarella commented 4 years ago

I didn't require self issued for my needs so it hasn't yet been implemented.

bcardarella commented 4 years ago

It seems like it would be trivial to implement though

CrowdHailer commented 4 years ago

Yeah. I've just finished walking through the Process in JS land. These were all the changes that were required. https://github.com/panva/node-openid-client/commit/c5d315826a767d1479509931eddb5ae6e3b99532

Might be a useful resource if only for the tests.

CrowdHailer commented 4 years ago

Would you be interested in adding support if I opened a PR?

Not sure when it will be, will try and get round to it soonish.

bcardarella commented 4 years ago

Yes definitely, I started work this AM but got pulled onto other things. If you're offering I'm taking :)

CrowdHailer commented 4 years ago

I'm still trying to work my way around the library. If you had some pointers on where I should start that would be great. Hopefully have more time to work on it next week.

On Wed, 15 Jan 2020, 21:20 Brian Cardarella, notifications@github.com wrote:

Yes definitely, I started work this AM but got pulled onto other things. If you're offering I'm taking :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DockYard/openid_connect/issues/26?email_source=notifications&email_token=ABMXHHQX5L5UEBOEL3TSUA3Q554YDA5CNFSM4KHE36Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJB26NA#issuecomment-574861108, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMXHHXZQH3XA4M7JNLCX23Q554YDANCNFSM4KHE36YQ .