search

DockYard / valid_field

https://hex.pm/packages/valid_field
MIT License
48 stars 6 forks source link

Update ecto to 1.1.8 #18

Closed gmile closed 8 years ago

gmile commented 8 years ago

I also checked the build against latest stable release of ecto, which is 2.0.2. Only one test failed:

  1) test passing changeset directly into assertions (ValidFieldTest)
     test/valid_field_test.exs:103
     ** (KeyError) key :model not found in: #Ecto.Changeset<action: nil, changes: %{first_name: "Test", last_name: "Something", title: "Something else"}, errors: [], data: #ValidField.Support.Model<>, valid?: true>
     stacktrace:
       (valid_field) lib/valid_field.ex:45: ValidField.assert_valid_field/2
       test/valid_field_test.exs:105: (test)

I think it may be good to have a published release of valid_field with latest ecto 1.x before moving on to ecto 2.0.

bcardarella commented 8 years ago

Agreed. I'll release 0.4 for Ecto 1.x. 0.5+ will target Ecto 2.x