Closed bcardarella closed 8 years ago
Currently we have both assert_valid_field and assert_invalid_field
assert_valid_field
assert_invalid_field
with_changeset(%User{}) |> assert_valid_field(:email, ["test@example.com"]) |> assert_invalid_field(:email, [nil, ""])
it would be nice to do the assertion in one line:
with_changeset(%User{}) |> assert_field(:email, ["test@example.com"], [nil, ""])
assert_field/4 could be implemented like:
assert_field/4
def assert_field(changeset, field, valid_values, invalid_values) do changeset |> assert_valid_field(field, valid_values) |> assert_invalid_field(field, invalid_values) end
Pros: a more concise syntax Cons: this could violate some people's 80 character column limit
If there is a :+1: on this I can implement
I like it 👍🏼
Currently we have both
assert_valid_field
andassert_invalid_field
it would be nice to do the assertion in one line:
assert_field/4
could be implemented like:Pros: a more concise syntax Cons: this could violate some people's 80 character column limit