Doclic / NoEncryption

Removes signatures from Minecraft chat messages
GNU General Public License v3.0
226 stars 18 forks source link

Exceptions when players are connecting/disconnecting on a Non-paper spigot server #108

Open jandie1505 opened 1 year ago

jandie1505 commented 1 year ago

Are you using the latest version of NoEncryption?

Is there an existing issue for this?

NoEncryption Version

5.1

Minecraft Version

1.19.4

Server Type/Build

This server is running CraftBukkit version 3763-Spigot-7d7b241-5a5e43e (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT)

Plugins in Use

Only NoEncryption

Startup/Running Logs

[12:17:39] [User Authenticator #1/INFO]: UUID of player jandie1505 is 55eda3b4-f5bb-4155-8b9b-a16f09c57aa3
[12:17:39] [Server thread/ERROR]: [NoEncryption] An error occurred while retrieving the player's channel for injection!
[12:17:39] [Server thread/ERROR]: Could not pass event PlayerJoinEvent to NoEncryption v5.1
org.bukkit.event.EventException: null
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot-api-1.19.4-R0.1-SNAPSHOT.jar:?]
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[spigot-api-1.19.4-R0.1-SNAPSHOT.jar:?]
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:589) ~[spigot-api-1.19.4-R0.1-SNAPSHOT.jar:?]
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:576) ~[spigot-api-1.19.4-R0.1-SNAPSHOT.jar:?]
    at net.minecraft.server.players.PlayerList.a(PlayerList.java:301) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.network.LoginListener.a(LoginListener.java:183) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.network.LoginListener.d(LoginListener.java:169) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.network.LoginListener.c(LoginListener.java:75) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.network.NetworkManager.a(NetworkManager.java:279) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.network.ServerConnection.c(ServerConnection.java:175) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1326) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.dedicated.DedicatedServer.b(DedicatedServer.java:388) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:1200) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1017) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:304) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.RuntimeException: java.lang.IllegalAccessException: class me.doclic.noencryption.compatibility.CompatiblePlayer cannot access a member of class net.minecraft.server.network.PlayerConnection with modifiers "private final"
    at me.doclic.noencryption.PlayerListener.onPlayerJoin(PlayerListener.java:22) ~[?:?]
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
    at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-api-1.19.4-R0.1-SNAPSHOT.jar:?]
    ... 15 more
Caused by: java.lang.IllegalAccessException: class me.doclic.noencryption.compatibility.CompatiblePlayer cannot access a member of class net.minecraft.server.network.PlayerConnection with modifiers "private final"
    at jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392) ~[?:?]
    at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674) ~[?:?]
    at java.lang.reflect.Field.checkAccess(Field.java:1102) ~[?:?]
    at java.lang.reflect.Field.get(Field.java:423) ~[?:?]
    at me.doclic.noencryption.compatibility.CompatiblePlayer.getChannel(CompatiblePlayer.java:29) ~[?:?]
    at me.doclic.noencryption.PlayerListener.onPlayerJoin(PlayerListener.java:19) ~[?:?]
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
    at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-api-1.19.4-R0.1-SNAPSHOT.jar:?]
    ... 15 more
[12:17:39] [Server thread/INFO]: jandie1505 joined the game
[12:17:39] [Server thread/INFO]: jandie1505[/127.0.0.1:42234] logged in with entity id 589 at ([world]-1066.0, 63.0, -215.0)
[12:17:45] [Server thread/INFO]: jandie1505 lost connection: Disconnected
[12:17:45] [Server thread/ERROR]: [NoEncryption] An error occurred while retrieving the player's channel for injection!
[12:17:45] [Server thread/ERROR]: Could not pass event PlayerQuitEvent to NoEncryption v5.1
org.bukkit.event.EventException: null
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot-api-1.19.4-R0.1-SNAPSHOT.jar:?]
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[spigot-api-1.19.4-R0.1-SNAPSHOT.jar:?]
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:589) ~[spigot-api-1.19.4-R0.1-SNAPSHOT.jar:?]
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:576) ~[spigot-api-1.19.4-R0.1-SNAPSHOT.jar:?]
    at net.minecraft.server.players.PlayerList.remove(PlayerList.java:521) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1790) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.network.NetworkManager.m(NetworkManager.java:444) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.network.ServerConnection.c(ServerConnection.java:195) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1326) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.dedicated.DedicatedServer.b(DedicatedServer.java:388) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:1200) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1017) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:304) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.RuntimeException: java.lang.IllegalAccessException: class me.doclic.noencryption.compatibility.CompatiblePlayer cannot access a member of class net.minecraft.server.network.PlayerConnection with modifiers "private final"
    at me.doclic.noencryption.PlayerListener.onPlayerQuit(PlayerListener.java:64) ~[?:?]
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
    at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-api-1.19.4-R0.1-SNAPSHOT.jar:?]
    ... 13 more
Caused by: java.lang.IllegalAccessException: class me.doclic.noencryption.compatibility.CompatiblePlayer cannot access a member of class net.minecraft.server.network.PlayerConnection with modifiers "private final"
    at jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392) ~[?:?]
    at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674) ~[?:?]
    at java.lang.reflect.Field.checkAccess(Field.java:1102) ~[?:?]
    at java.lang.reflect.Field.get(Field.java:423) ~[?:?]
    at me.doclic.noencryption.compatibility.CompatiblePlayer.getChannel(CompatiblePlayer.java:29) ~[?:?]
    at me.doclic.noencryption.PlayerListener.onPlayerQuit(PlayerListener.java:61) ~[?:?]
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
    at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-api-1.19.4-R0.1-SNAPSHOT.jar:?]
    ... 13 more
[12:17:45] [Server thread/INFO]: jandie1505 left the game
[12:17:48] [Craft Scheduler Thread - 2/WARN]: [NoEncryption] Plugin NoEncryption v5.1 generated an exception while executing task 6
java.util.ConcurrentModificationException: null
    at java.util.HashMap.forEach(HashMap.java:1424) ~[?:?]
    at me.doclic.noencryption.utils.ServerChannelGC.runGC(ServerChannelGC.java:18) ~[?:?]
    at org.bukkit.craftbukkit.v1_19_R3.scheduler.CraftTask.run(CraftTask.java:82) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at org.bukkit.craftbukkit.v1_19_R3.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54) ~[spigot-1.19.4-R0.1-SNAPSHOT.jar:3763-Spigot-7d7b241-5a5e43e]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
    at java.lang.Thread.run(Thread.java:833) ~[?:?]

Reproducible Test

  1. Install NoEncryption on a Spigot 1.19.4 Server (not paper, the bug does not occur on paper).
  2. Connect to the server
  3. The error will occur
  4. Disconnect from the server
  5. The error will occur again

Anything else?

No response