search

Doclic / NoEncryption

Removes signatures from Minecraft chat messages
GNU General Public License v3.0
225 stars 18 forks source link

Geyser player cannot login on 1.19.3 server anymore (since latest updates) #82

Closed NyaomiDEV closed 1 year ago

NyaomiDEV commented 1 year ago

Are you using the latest version of NoEncryption?

Is there an existing issue for this?

NoEncryption Version

5.0

Minecraft Version

1.19.3

Server Type/Build

Paper version git-Paper-417 (MC: 1.19.3) (Implementing API version 1.19.3-R0.1-SNAPSHOT) (Git: 0620289)

Plugins in Use

Relevant: ViaVersion, Geyser, Floodgate, ProtocolLib. (Reproduced in test environment)

Startup/Running Logs

[11:57:57] [Geyser Spigot connection thread-4-3/WARN]: [ViaVersion] ERROR IN Protocol1_19_4To1_19_3 IN REMAP OF SERVER_DATA (0x41)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]: io.netty.handler.codec.EncoderException: com.viaversion.viaversion.exception.InformativeException: Please report this on the Via support Discord or open an issue on the relevant GitHub repository
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]: Source 0: com.viaversion.viaversion.protocols.protocol1_19_4to1_19_3.Protocol1_19_4To1_19_3$$Lambda$5414/0x0000000801b148d0
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:107)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:881)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:863)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:968)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:856)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:113)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:881)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:863)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:968)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:856)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:120)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:881)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:863)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:968)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:856)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.ChannelDuplexHandler.write(ChannelDuplexHandler.java:115)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at NoEncryption-1.19.3-5.0.jar//me.doclic.noencryption.PlayerListener$1.write(PlayerListener.java:35)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:879)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:940)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:966)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:934)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:1020)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:311)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at Geyser-Spigot.jar//org.geysermc.geyser.network.netty.ChannelWrapper.writeAndFlush(ChannelWrapper.java:218)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ProtocolLib.jar//com.comphenix.protocol.injector.netty.channel.NettyChannelProxy.writeAndFlush(NettyChannelProxy.java:227)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ProtocolLib.jar//com.comphenix.protocol.injector.netty.channel.NettyChannelProxy.writeAndFlush(NettyChannelProxy.java:233)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at net.minecraft.network.NetworkManager.doSendPacket(NetworkManager.java:459)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at net.minecraft.network.NetworkManager.lambda$sendPacket$11(NetworkManager.java:433)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ProtocolLib.jar//com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.lambda$proxyRunnable$2(NettyEventLoopProxy.java:48)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at java.base/java.lang.Thread.run(Thread.java:833)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]: Caused by: com.viaversion.viaversion.exception.InformativeException: Please report this on the Via support Discord or open an issue on the relevant GitHub repository
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]: Source 0: com.viaversion.viaversion.protocols.protocol1_19_4to1_19_3.Protocol1_19_4To1_19_3$$Lambda$5414/0x0000000801b148d0
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]: Caused by: java.lang.StringIndexOutOfBoundsException: begin 22, end 0, length 0
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at java.base/java.lang.String.checkBoundsBeginEnd(String.java:4602)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at java.base/java.lang.String.substring(String.java:2705)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at java.base/java.lang.String.substring(String.java:2678)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ViaVersion-4.6.1.jar//com.viaversion.viaversion.protocols.protocol1_19_4to1_19_3.Protocol1_19_4To1_19_3.lambda$registerPackets$0(Protocol1_19_4To1_19_3.java:84)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ViaVersion-4.6.1.jar//com.viaversion.viaversion.api.protocol.AbstractProtocol.transform(AbstractProtocol.java:341)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ViaVersion-4.6.1.jar//com.viaversion.viaversion.protocol.packet.PacketWrapperImpl.apply(PacketWrapperImpl.java:389)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ViaVersion-4.6.1.jar//com.viaversion.viaversion.protocol.packet.PacketWrapperImpl.apply(PacketWrapperImpl.java:377)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ViaVersion-4.6.1.jar//com.viaversion.viaversion.protocol.packet.PacketWrapperImpl.apply(PacketWrapperImpl.java:44)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ViaVersion-4.6.1.jar//com.viaversion.viaversion.protocol.ProtocolPipelineImpl.transform(ProtocolPipelineImpl.java:122)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ViaVersion-4.6.1.jar//com.viaversion.viaversion.connection.UserConnectionImpl.transform(UserConnectionImpl.java:312)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ViaVersion-4.6.1.jar//com.viaversion.viaversion.connection.UserConnectionImpl.transformClientbound(UserConnectionImpl.java:291)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ViaVersion-4.6.1.jar//com.viaversion.viaversion.bukkit.handlers.BukkitEncodeHandler.encode(BukkitEncodeHandler.java:57)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ViaVersion-4.6.1.jar//com.viaversion.viaversion.bukkit.handlers.BukkitEncodeHandler.encode(BukkitEncodeHandler.java:35)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:90)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:881)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:863)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:968)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:856)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:113)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:881)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:863)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:968)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:856)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:120)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:881)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:863)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:968)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:856)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.ChannelDuplexHandler.write(ChannelDuplexHandler.java:115)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at NoEncryption-1.19.3-5.0.jar//me.doclic.noencryption.PlayerListener$1.write(PlayerListener.java:35)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:879)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:940)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:966)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:934)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:1020)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:311)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at Geyser-Spigot.jar//org.geysermc.geyser.network.netty.ChannelWrapper.writeAndFlush(ChannelWrapper.java:218)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ProtocolLib.jar//com.comphenix.protocol.injector.netty.channel.NettyChannelProxy.writeAndFlush(NettyChannelProxy.java:227)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ProtocolLib.jar//com.comphenix.protocol.injector.netty.channel.NettyChannelProxy.writeAndFlush(NettyChannelProxy.java:233)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at net.minecraft.network.NetworkManager.doSendPacket(NetworkManager.java:459)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at net.minecraft.network.NetworkManager.lambda$sendPacket$11(NetworkManager.java:433)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at ProtocolLib.jar//com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.lambda$proxyRunnable$2(NettyEventLoopProxy.java:48)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
[11:57:57] [Geyser Spigot connection thread-4-3/WARN]:  at java.base/java.lang.Thread.run(Thread.java:833)

Reproducible Test

Try to join from Bedrock on a Geyser-Floodgate compatible server.

Anything else?

Of course I am putting this here since telling the ViaVersion guys to support NoEncryption is questionable.

V1nc3ntWasTaken commented 1 year ago

Working on something now