Closed V1nc3ntWasTaken closed 1 year ago
What type of fix(es) are included in this pull request?
List of links to issues that this PR relates to or closes
Describe all the changes that were made
Optional#orElse(null)
""
byte[]
Do the applied changes require testing? (Depends on if core components were changed)
By creating a pull request, you agree to the following
Type of Change
What type of fix(es) are included in this pull request?
Other (Only applies if Other is selected above)
-
Link(s) to related issue(s) and their issue number(s)
List of links to issues that this PR relates to or closes
82
Changes
Describe all the changes that were made
Optional#orElse(null)
fallbacks to Optionals to replace empty string fallbacks. (""
)byte[]
Optional.Testing Required
Do the applied changes require testing? (Depends on if core components were changed)
Testing Environment (If the above is Yes)
1.19 Tests - Server Distribution (CraftBukkit, Spigot, Purpur, and it's build number): N/A - [ ] ~~Tested player joining~~ - [ ] ~~Tested chats **Player -> Server**~~ - [ ] ~~Tested command chats **Player -> Server** (Using /tell, /me, /say, etc.)~~ - [ ] ~~Tested chats **Server -> Player** (Using /say, /me, etc.)~~ - [ ] ~~Tested chat formatting (Using third party plugins such as TownyChat, EssentialsXChat, etc.)~~ - [ ] ~~Tested Reflection with above~~
1.19.1 Tests - Server Distribution (CraftBukkit, Spigot, Purpur, and it's build number): Purpur 1.19.1 Build 1751 - [X] Tested player joining - [ ] ~~Tested chats **Player -> Server**~~ - [ ] ~~Tested command chats **Player -> Server** (Using /tell, /me, /say, etc.)~~ - [ ] ~~Tested chats **Server -> Player** (Using /say, /me, etc.)~~ - [ ] ~~Tested chat formatting (Using third party plugins such as TownyChat, EssentialsXChat, etc.)~~ - [X] Tested Reflection with above
1.19.2 Tests - Server Distribution (CraftBukkit, Spigot, Purpur, and it's build number): Purpur 1.19.2 Build 1858 - [X] Tested player joining - [ ] ~~Tested chats **Player -> Server**~~ - [ ] ~~Tested command chats **Player -> Server** (Using /tell, /me, /say, etc.)~~ - [ ] ~~Tested chats **Server -> Player** (Using /say, /me, etc.)~~ - [ ] ~~Tested chat formatting (Using third party plugins such as TownyChat, EssentialsXChat, etc.)~~ - [X] Tested Reflection with above
1.19.3 Tests - Server Distribution (CraftBukkit, Spigot, Purpur, and it's build number): Purpur 1.19.3 Build 1920 - [X] Tested player joining - [ ] ~~Tested chats **Player -> Server**~~ - [ ] ~~Tested command chats **Player -> Server** (Using /tell, /me, /say, etc.)~~ - [ ] ~~Tested chats **Server -> Player** (Using /say, /me, etc.)~~ - [ ] ~~Tested chat formatting (Using third party plugins such as TownyChat, EssentialsXChat, etc.)~~ - [X] Tested Reflection with above
1.19.4 Tests - Server Distribution (CraftBukkit, Spigot, Purpur, and it's build number): Purpur 1.19.4 Build 1939 - [X] Tested player joining - [ ] ~~Tested chats **Player -> Server**~~ - [ ] ~~Tested command chats **Player -> Server** (Using /tell, /me, /say, etc.)~~ - [ ] ~~Tested chats **Server -> Player** (Using /say, /me, etc.)~~ - [ ] ~~Tested chat formatting (Using third party plugins such as TownyChat, EssentialsXChat, etc.)~~ - [X] Tested Reflection with above Special Tests - [X] Tested with environment from linked issue
Self Review