search

Doctave / doctave

A batteries-included developer documentation site generator
https://cli.doctave.com
MIT License
566 stars 32 forks source link

Add BASE_PATH to Prism autoloader languages_path #40

Closed oeb25 closed 2 years ago

oeb25 commented 2 years ago

This change prefixes the Prism grammar folder (assets/prism-grammars/) with the base path, used when autoloading grammers.

begleynk commented 2 years ago

Thanks for opening this! This sounds like something that should be put into a point release asap, since it would seem syntax highlighting breaks when using a non-standard base path.

Should really figure out a better way to do some browser testing as part of a release - this isn't the first time a bug like this has made it into a release since the Rust tests can't check for JS interactions in the browser.

I'll get back to this soon.

djcass44 commented 2 years ago

@begleynk anything we can do to help get this MR through? I use Doctave in GitLab Pages so it's always under a sub-path, and I would really like to have syntax highlighting working again.

begleynk commented 2 years ago

@begleynk anything we can do to help get this MR through? I use Doctave in GitLab Pages so it's always under a sub-path, and I would really like to have syntax highlighting working again.

Sorry for the delay on this. My priorities regarding this project have changed a bit in the last few months so this had fallen off my radar. I'm going to make a 0.4.2 release with this fix now!