search

DoctorD1501 / JAVMovieScraper

Scrape XBMC and Kodi movie metadeta and automatically rename files for Japanese Adult Videos (JAV), American Adult DVDs, and American Adult Webcontent
GNU General Public License v2.0
755 stars 161 forks source link

Extremely slow on network drive #8

Closed shad00m closed 9 years ago

shad00m commented 9 years ago

The program freezes after every click on anything on a network drive in windows for a couple of seconds. Moving takes about 30 seconds or more where when its attached directly via USB only takes less than 1 second.

DoctorD1501 commented 9 years ago

Hi shad00m,

I also use the program with folders on a network drive and performance seems to be OK most of the time. Are you using the newest build of the program?

Also, how fast does browsing your network drive in windows explorer seem? When the program freezes, does the animated cursor go to the busy cursor?

What type of system are the remote files on? (Unix, Windows, Mac) and what protocol have you set up the share with (e.g. SAMBA, NFS?)

Thanks.

shad00m commented 9 years ago

I tried the latest build Network drives seem to operate faster but Selecting a new file still takes like 2-3 seconds and the more you select the slower it will get until it freezes for a couple of seconds (little annoying but much better than before) Scraping of 4 videos takes 1-2 minutes.(which seem okay) Writing files of 4 videos takes about 1-2 minutes. (ok as well)

In explorer the network drive is explored in an instant and files open instantly as well. The cursor does not change when the program freezes while selecting files.

The network drive uses the SAMBA protocol on a ARM router (Asus RT-N66U) running modified Asus firmware "Asuswrt-Merlin" with the Linux kernel 2.6.22.19. Accessing is quick and without any freezes on OSX, Debian, Win7, Win8 and Android

shad00m commented 9 years ago

I just noticed when trying to edit the rename settings it completely freezes up with 12% cpu load on a xeon 1230v2 no matter if I selected a NAS directory or not.

DoctorD1501 commented 9 years ago

The slow performance as you select more and more files is due to the somewhat lazy way I wrote the select file method where the program rereads in every file's nfo each time a new file is selected. So if you had 4 selected and you clicked the 5th, it reads in all 5 files again instead of just one. Clearly I'll need to revisit this at some point so that things run a little bit more speedy.

Scraping a video is mostly affected by network performance of the sites that are being scraped, and to a certain extent writing the files does too. This is because if you've selected the option to download extrafanart and trailers, those files need to all be downloaded from the website when writing them out. Does writing a file go much faster when saving on a local drive for you?

The rename settings freeze is unrelated to a network drive I think and should happen no matter what kind of drive you're running the program with. What's happening is the matcher for the pattern matches whenever you type something and if there's a pattern which takes a long time to execute (because it may be pattern which can never finish or take a very long time to do so) it freezes the whole program. Issue #13 has more info on needing to do a rewrite of the rename screen to get it working properly!

DoctorD1501 commented 9 years ago

The rename settings freeze should be fixed now. (Commit 354fef569dc3a72e3dc71ef708cf181dce6c8158)

DoctorD1501 commented 9 years ago

I'm going to close this issue for now as I've made many performance tweaks since it was opened. It seems usable to me on my own network drive in terms of performance. If you're still having problems with performance on the newest build, let me know by leaving a new comment in this issue or open a new one.

Thanks.