search

DoctorDiLauro / navigation-highlight

A code exercise to practice highlighting the current page in website navigation.
0 stars 0 forks source link

Screenshot issue #1

Open DoctorDiLauro opened 8 years ago

DoctorDiLauro commented 8 years ago

Got everything on Markbot working fine but the screenshots.

@thomasjbradley

thomasjbradley commented 8 years ago

Looking at the screenshot split view I can see a few things that need changing.

  1. The headings are different colours: screen shot 2016-02-26 at 1 48 04 pm
  2. Your navigation doesn't completely fit on a single line, like mine: screen shot 2016-02-26 at 1 48 40 pm

Fixing those two big things might get you a bunch closer.

DoctorDiLauro commented 8 years ago

Ah yeah, I can tell with them side by side like that. Thanks Thomas, I'll get back at it!

On Fri, Feb 26, 2016 at 1:49 PM, Thomas J Bradley notifications@github.com wrote:

Looking at the screenshot split view I can see a few things that need changing.

1.

The headings are different colours: [image: screen shot 2016-02-26 at 1 48 04 pm] https://cloud.githubusercontent.com/assets/105192/13361905/996c831e-dc8f-11e5-9d72-f4a1fe7caed4.png 2.

Your navigation doesn't completely fit on a single line, like mine: [image: screen shot 2016-02-26 at 1 48 40 pm] https://cloud.githubusercontent.com/assets/105192/13361927/a7c6b984-dc8f-11e5-940d-085d482e2790.png

Fixing those two big things might get you a bunch closer.

— Reply to this email directly or view it on GitHub https://github.com/DoctorDiLauro/navigation-highlight/issues/1#issuecomment-189420775 .

thomasjbradley commented 8 years ago

The newest version of Markbot has that feature built into it—click on the screenshot in the error list and it pops open that window.

DoctorDiLauro commented 8 years ago

Oh wicked, thanks!