Get server list on module install rather than on NPM publish

DoctorMcKay / node-steam-client

API-compatible fork of node-steam's SteamClient

https://steamcommunity.com/groups/SteamRE/discussions/1/

MIT License

52 stars 19 forks source link

Get server list on module install rather than on NPM publish #4

Closed sturadnidge closed 7 years ago

sturadnidge commented 7 years ago

This module looks pretty stable... maybe more stable than the CM server list. In which case, might make sense to pull the current list on module install rather than when publishing to NPM?

DoctorMcKay commented 7 years ago

I'd rather not include any postinstall scripts, to keep things simple. The WebAPI has far from 100% uptime and I'd rather not break npm installs when it's down/slow/having issues. The CM list is pretty stable and as long as the majority of addresses are valid, the module will find a good one and get connected. Once connected, a new batch of addresses is sent down and saved for future use.

DoctorMcKay commented 7 years ago

logOn needs to exist here as that's where the protocol version is sent.

sturadnidge commented 7 years ago

sorry I shouldn't have put in a merge request on my master, I'm branching way off now :)

logOn doesn't need to exist in here for that purpose, you have this section which adds protocol version to any ClientLogon message types - the logOn method implemented in here has redundant code unless I'm reading that wrong?