search

Docx2Src / Serialize.OpenXml.CodeGen

.NET assembly class responsible for converting OpenXml based documents into corrisponding dotnet code
MIT License
39 stars 6 forks source link

fixed error with setting DateTime property #5

Closed vtgrady2k closed 2 years ago

vtgrady2k commented 2 years ago

fixed the following error: System.ArgumentException Invalid Primitive Type System.DateTime. Consider using CodeObjectCreateExpression

rmboggs commented 2 years ago

Hi,

Thank you for this change. I'm going to run this through to see how it looks. If it's ok, I'll pull it in.

Thanks, Ryan

vtgrady2k commented 2 years ago

No problem! Nice work on this by the way, this code worked great for generating the document templates I needed for another project I'm working on.

Mike

rmboggs commented 2 years ago

Thanks for your kind words.

Looks ok. Can you do 2 quick things if possible?

If not, I can do it but it would help me out if you can put those items in there.

vtgrady2k commented 2 years ago

Sure thing, you go it.

On Feb 22, 2022, at 1:08 PM, Ryan Boggs @.***> wrote:

Thanks for your kind words.

Looks ok. Can you do 2 quick things if possible?

Add a comment on the new section saying something to the effect of DateTime values need to be handled differently than other simple types, just so it is quick to understand what is going on in there. Add a note to the change log in the fixed section of the upcoming 0.5.0-beta release. Feel free to add a note saying "fixed by vtgrady2k" if you like If not, I can do it but it would help me out if you can put those items in there.

— Reply to this email directly, view it on GitHub https://github.com/rmboggs/Serialize.OpenXml.CodeGen/pull/5#issuecomment-1048072986, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXYSZMKCKJOXMCKHOO3T4L3U4PGLRANCNFSM5OP2FJTQ. You are receiving this because you authored the thread.

rmboggs commented 2 years ago

Perfect, thank you for your help. :)