search

Doddler / RagnarokRebuildTcp

Ragnarok-like server + client
140 stars 37 forks source link

Copy data from client data folder - completes with 50 errors #13

Open luislhg opened 1 week ago

luislhg commented 1 week ago

I have run the Copy data from client data folder, took a couple of hours, it completed but has 50 errors.

Are these expected, or maybe a different version of data folder? It's korean, it passed the test, mostly copied successfully... not sure if the date/version matters or something hard coded is expected or just my data is not the same one as yours image

Any help is appreciated, thanks

luislhg commented 1 week ago

Apparently 39 of the 50 errors are because Assets/Sprites/Icons folder doesn't exist.

I simply added this to ItemIconImporter.cs to fix: image

The other errors still remain...

Doddler commented 1 week ago

At some point I'll have to go through and do a fresh clone of the repo and correct issues I encounter. Unfortunately as you've no doubt noticed it's not a fast process, so it's difficult to make sure the repo can easily be cloned, and it's also pretty easy to introduce errors because I'm intentionally excluding any data imported from the proper client. This will probably become a bigger issue as time goes on, especially if I keep adding custom stuff...

Well, for now I've fixed the icon importer issue. Some of the issues in the log there are expected, some unused sprites and assets are broken within the client so they'll end up logged here. I'll do a fresh clone once I finish equipment and make sure everything can be started correctly. Good job on getting it working though, as I mentioned in the readme making sure it's easy to clone hasn't been a big priority so far so I'm at least glad with some workshopping you were able to get it going.

I'll leave this issue open until i can go through and correct any issues on a fresh clone.