search

Dogacel / kotlinx-protobuf-gen

Generate kotlinx serializable data classes from protobuf
Apache License 2.0
12 stars 3 forks source link

chore: update protobuf to latest #23

Open sgammon opened 1 month ago

sgammon commented 1 month ago

Hey! Cool project. I'd like to contribute and potentially use it in some of my work. Can I help contribute? 😄

First up, here is a PR which updates Protobuf to the latest version (4.28.1 at the time of this writing). It includes some transition internally to Protocol Buffer Editions, which happen to provide a nicer API for some of the stuff needed by this plugin.

I've updated in the places I think need it, and done a little clean up along the way. Please make sure, though, that I've done this right according to the codebase's styles and so on. The tests pass and we intend to use the lib downstream. Cheers!

sgammon commented 1 month ago

cc / @Dogacel

Dogacel commented 2 weeks ago

@sgammon hi, just checking in as this PR has became stale.

sgammon commented 1 week ago

@Dogacel Sorry, got busy with work... we don't need this component quite yet, but we will soon. Thank you for your review comments. Why don't I re-file this week after some cleanup? 😄

Dogacel commented 1 week ago

@Dogacel Sorry, got busy with work... we don't need this component quite yet, but we will soon. Thank you for your review comments. Why don't I re-file this week after some cleanup? 😄

Sure! Waiting for it 🙂