search

DogeChia / doge-chia

DogeChia blockchain python implementation (full node, farmer, harvester, timelord, and wallet)
https://dogechi.org
Apache License 2.0
25 stars 8 forks source link

Solve RPC port conflicts with thyme #9

Closed Jsewill closed 3 years ago

Jsewill commented 3 years ago

These two new port numbers do not currently conflict with most active chia forks, nor chia itself.

Ilmairinen commented 3 years ago

Hello @Jsewill - Thank you for identifying the issue and proposing a fix. We had a few isolated reports of this port conflict but couldn't duplicate it as none of us are running Thyme. We discussed it and have decided not to implement this port change, as it would create support issues for our existing users on the next upgrade. We suggest that Thyme project choose another RPC port for it's wallet.

Jsewill commented 3 years ago

Thanks for your consideration of this pull request. I'd be curious to know, as it is simply a change that impacts the configuration initialization, how would this negatively impact existing users? Existing users wishing to run thyme would simply have to update their configuration. Finally, if it is a question of which repository was here first, thyme has dogechia beat by a few hours, at least according to the github api.