ddim seems to be broken when using with Deforum

osi1880vr commented 2 years ago

Im trying to get deforuum working and just stumble acros your new memory management. For me it did break at least ddim maybe more im still testing. plsm is just working. I found one issue in ddim which is a missing option fill for make_ddim_timesteps in diffusionmodules/util.py

elif ddim_discr_method == 'fill':
    ddim_timesteps = np.linspace(0, num_ddpm_timesteps-1,num_ddim_timesteps+1).astype(int)

this I found missing. but then I still get errors from torch grad_mode in a _DecoratorContextManager This all is way out of my line of understanding ;) Maybe you find the time to see whats wrong there with ddim. If it helps I will provide you with a repo where you can see it happen

Ehplodor commented 2 years ago

Did you mean to post this issue in Deforum repository ?

osi1880vr commented 2 years ago

Not really 😊

I used your ldm folder to get the memory tricks all into my deforum repo…

But with something you did the ddim sampler is broken.

I dont see directly how this is a deforum issue as the change came from you.

In my world what ever change you do in ldm should not harm consumers of ldm…

Maybe im wrong an ddim is broken because of deforum.. but until i know that for sure i come to you 😉

Von: Ehplodor @.> Gesendet: Freitag, 16. September 2022 13:01 An: Doggettx/stable-diffusion @.> Cc: osi1880vr @.>; Author @.> Betreff: Re: [Doggettx/stable-diffusion] ddim seems to be broken when using with Deforum (Issue #15)

Did you mean to post this issue in Deforum repository ?

— Reply to this email directly, view it on GitHub https://github.com/Doggettx/stable-diffusion/issues/15#issuecomment-1249226865 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AU2U5IFCM6T5QTQ3A7U4GX3V6RHN7ANCNFSM6AAAAAAQNYI7IE . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AU2U5ICHO5AN3TMR3PVQWF3V6RHN7A5CNFSM6AAAAAAQNYI7IGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSKOWYHC.gif Message ID: @. @.> >

Doggettx / stable-diffusion

ddim seems to be broken when using with Deforum #15