search

Dogstudio / highway

Highway - A Modern Javascript Transitions Manager
https://highway.js.org/
MIT License
1.43k stars 92 forks source link

Wordpress search results problem #23

Closed wezzou1 closed 6 years ago

wezzou1 commented 6 years ago

Hi!

I'm using wordpress and highway on my site, but when I search on my page, the searchresults display's as normal, but something seems to be off, when I'm clicking at my logotype (Go back to start) the transition is running and the route-view change as it should, But the content dosen't change? what can be problem here?

The url be like name.localhost/?s=mysearch&post_type=product

ThaoD5 commented 6 years ago

Hello @wezzou1, we came across the same issue (search results on homepage with a wordpress website) on our last production at Dogstudio, we plan to have a look at it as soon as possible in order to understand precisely what is going on and why this is happening.

We will keep this issue updated with the results of our investigation and ping you on the response as soon as we get there :-)

Hope you're enjoying Highway !

Thao

ThaoD5 commented 6 years ago

We quickly had a look just right now, and the reason seems to come from the caching of the pages, the pages are currently cached without the get parameters, so the search is cached as "name.localhost", thus replacing the content of the homepage by what is cached : the search

We'll have a look at this probably later today and see if we get this to work properly as soon as possible :-)

Thanks for your input on this issue @wezzou1 :-)

Thao

ThaoD5 commented 6 years ago

@wezzou1 We just had a look and it was indeed the caching of the pages that was not enough precise concerning the name of the page to be cached

We fixed this issue in latest version v2.0.2 that is now released, we tested the fix on the concerned last production, and it now works like a charm.

Can you confirm us that you do not have any trouble with this anymore ?

Don't hesitate to send us the site you're making using Highway, we're always interested in sharing them in the demo page

Thao

wezzou1 commented 6 years ago

@ThaoD5 Thank you for a fast response and that quick fix! you are the best! It's working like a charm! :) 💯 👍

wezzou1 commented 6 years ago

@ThaoD5 Oh, i forgot, if you wanna see what i'm working on you can check it out at http://norrlands.dev.fmca.se/ Still in progress, I will send you the full link when it's all done!

ThaoD5 commented 6 years ago

@wezzou1 Ah yes, I already saw it because you opened another issue previously :-) Glad to see everything goes smoothly 👍