Closed joshkirk-zero closed 6 years ago
Woaw @joshkirk-zero great work here, we're definitely going to have a look tomorrow at your solution for this issue !
Thanks already for coming up with a complete solution and this nice explaining comment, we will keep you updated as soon as possible, but it seems really promising !
Have a great night!
Thanks @joshkirk-zero! I quickly checked the changes committed and it already looks awesome. Give me a bit of time to completely review everything and I'll create a new release when done and keep you in touch here or by email.
Nice I'm glad you like it đź‘Ť
A couple other small notes now that I've had another night to think about it..
I can't think of anything else at the moment, but I'm available for further discussion.
Thank you
As proposed, here is the ability to use contextual transitions. Meaning, a transition that fires when clicking a certain link.
Here are some notes:
To accomplish this we:
this.Transitions
in the core constructorthis.contextualTransition
to false (default)navigate(e)
, check if the clicked anchor hasdata-transition
if it does, setthis.contextualTransition
to the transition. Else set it to false.hide()
andshow()
functions, we pass inthis.contextualTransition
, which is passed all the way to the transition itself.transition.js
we check whether the contextual transition is false, if not we use the contextual transition. If it is false, we simply use the transition from the view.this.contextualTransition
to false no matter what, since we should use the default/view transition when navigating via browser buttons.