search

Dogstudio / highway

Highway - A Modern Javascript Transitions Manager
https://highway.js.org/
MIT License
1.43k stars 92 forks source link

Http vs https #40

Closed wezzou1 closed 6 years ago

wezzou1 commented 6 years ago

Hi again!,

I just mentioned that it is not possible to click on links that have different http/https,

https -> https links works fine http -> http links works fine

https -> http dosen't work http -> https dosen't work

Of course, all links will be http, or https, but I have managed to get different on some links for now

Anthodpnt commented 6 years ago

Hi @wezzou1,

Like you said all links internal to your project SHOULD have the same protocol IMO. If you have links with different protocol thos should be external ones and don’t need Highway then.

I don’t think this is an issue of Highway to not support this kind of behavior but more an issue of logic in how links are managed on the website.

wezzou1 commented 6 years ago

@Anthodpnt yes, of course, but I think it will be good, if the links dosn't need Highway I think it will act lika a normal link? Let's say, that some link are broken, or something, and if clicking on it, it will return false and create a extern link?

wezzou1 commented 6 years ago

If the link dosen't support "highway" It's now get an error in console, and dosen't go to click on it. I think it would be better if the site "hard-reload" if the links are wrong

Anthodpnt commented 6 years ago

@wezzou1 Highway already hard-reload the link when it’s a 404 error or if the link has a different origin... We cannot do more to know if the link is Highway compatible or not... If you want to disable Highway on some links for personal reasons please follow the guide to do it. We are already providing everything you need to manage the links on your website the way you want.

This request is not relevant enough to be added to Highway since it’s a really specific use case and that the initial issue is not related to Highway but to logic in how links are managed.