Open JohnstonJ opened 3 months ago
Describe the bug The SMDegrain filter crashes with error:
To Reproduce
This simple filter statement seems adequate to trigger it:
SMDegrain(prefilter=1)
Prefilter 2 is also broken in the same way.
Expected behavior
The prefilter should be run and applied as part of image processing.
System:
Additional context
At https://github.com/Dogway/Avisynth-Scripts/blob/31459ff64fa39a3ea00b5cabb288e980b57a5b00/SMDegrain/SMDegrain.avsi#L320-L321 I notice that a special string is passed to ex_MinBlur containing the named parameter Y=Lum that is to be passed to ex_Median.
ex_MinBlur
Y=Lum
ex_Median
Later on, it is passed to Eval, for evaluation inside the ex_MinBlur function. However, that function does not have any variable named Lum in it, and thus I think that is probably the source of the error. https://github.com/Dogway/Avisynth-Scripts/blob/31459ff64fa39a3ea00b5cabb288e980b57a5b00/SMDegrain/SMDegrain.avsi#L779
Eval
Lum
If I change the ex_Median call to read """ex_Median(mode="horizontal" ,Y=Y,UV=uv)""", then the SMDegrain filter will run successfully, but I am not familiar enough with this filter to know whether the results are as expected or not.
"""ex_Median(mode="horizontal" ,Y=Y,UV=uv)"""
Describe the bug The SMDegrain filter crashes with error:
To Reproduce
This simple filter statement seems adequate to trigger it:
Prefilter 2 is also broken in the same way.
Expected behavior
The prefilter should be run and applied as part of image processing.
System:
Additional context
At https://github.com/Dogway/Avisynth-Scripts/blob/31459ff64fa39a3ea00b5cabb288e980b57a5b00/SMDegrain/SMDegrain.avsi#L320-L321 I notice that a special string is passed to
ex_MinBlurcontaining the named parameterY=Lumthat is to be passed toex_Median.Later on, it is passed to
Eval, for evaluation inside theex_MinBlurfunction. However, that function does not have any variable namedLumin it, and thus I think that is probably the source of the error. https://github.com/Dogway/Avisynth-Scripts/blob/31459ff64fa39a3ea00b5cabb288e980b57a5b00/SMDegrain/SMDegrain.avsi#L779If I change the
ex_Mediancall to read"""ex_Median(mode="horizontal" ,Y=Y,UV=uv)""", then the SMDegrain filter will run successfully, but I am not familiar enough with this filter to know whether the results are as expected or not.