Doichain / dapp

Doichan dApp - a Meteor.js implementation of the "Doichain Atomic Double-Opt-In" Protocol
https://www.doichain.org
MIT License
6 stars 6 forks source link

Reduce docker images size of doichain/dapp #141

Open silkroadnomad opened 4 years ago

silkroadnomad commented 4 years ago

Based of the analyzis of https://github.com/Doichain/dapp/issues/139 please create new improved Dockerfile in order to reduce the docker image size. Please use branch 0.0.9!

jay-dee7 commented 4 years ago

hey @inspiraluna i think it would be safe to remove the doichain-core source code related directory after the build process is done? i'm refering to this content after make install since after make, the compiled code goes in /usr/local/bin/ and we don't really need the source at all:

Screenshot 2020-03-14 at 3 07 16 PM
silkroadnomad commented 4 years ago

yes, I guess thats a good idea. In the beginning we were often doing hot code fixes inside the image and compiled it afterwards again. But now it could truly be removed.!

jay-dee7 commented 4 years ago

@inspiraluna i tried removing it, however it didn't help much with reducing the size at all. It's taking longer than what i anticipated :(

jay-dee7 commented 4 years ago

@inspiraluna i've created a new PR here --> added alpine docker image, which reduces the size of the docker image from 1.7GB to 968MB. I have also added a doc, which explains about how to build the alpine image and also how to run the resulting image --> how to guide for alpine image