search

Doist / RecyclerViewExtensions

RecyclerView made easier.
MIT License
495 stars 42 forks source link

⛔ [Draft] ⛔ Initial change of `Model.id` type from `Long` to `String` #49

Closed siarhei-kazlou closed 2 years ago

siarhei-kazlou commented 2 years ago

Initial change of Model.id type from Long to String

goncalossilva commented 2 years ago

@siarhei-kazlou I suggest considering Any, or better yet, a generic type, instead of using String directly.

We're transitioning to String internally, but this is a generalized OSS project and the truth is that RV is typically used with Long (Adapters actively encourage that, unfortunately). It would be good to consider a design that supports the most common approach. :)

siarhei-kazlou commented 2 years ago

It was decided to keep using long IDs since they are more aligned to the place of usage (RV and related logic). 🙂 Maybe we'll return to some kind of selection generalization in the future. But it's prematurely for now. 🤔