search

Doist / RecyclerViewExtensions

RecyclerView made easier.
MIT License
495 stars 42 forks source link

Pinch zoom #6

Closed goncalossilva closed 8 years ago

goncalossilva commented 8 years ago

This PR adds yet another extension with "pinch zoom" support.

One note about using translations instead of an ItemDecoration: Using an ItemDecoration fails to work as child views can be offset until they are out of the screen. There are rendering problems and unwanted scroll when this happens. Using regular translations circumvents this and seems logically more correct.

ab-helly commented 8 years ago

Everything looks good and works great :)

ab-helly commented 8 years ago

LGTM. PS: Is the LGTM label missed here for a specific reason?

goncalossilva commented 8 years ago

Thanks for reviewing Olga! LGTM is not here because it was never created :smile: No reason for it being absent!