Doist / RecyclerViewExtensions

RecyclerView made easier.
MIT License
495 stars 42 forks source link

Drag & drop improvements #7

Closed goncalossilva closed 8 years ago

goncalossilva commented 8 years ago

This PR improves drag & drop by merging the best ideas from the previous DragDropManager and ItemTouchHelper into a new class with a new workflow, DragDropHelper. There's also a tiny fix to StickyHeadersLinearLayoutManager's position tracking on moves, detected while implementing it.

Reasons for not sticking with DragDropManager:

Reasons for not sticking with ItemTouchHelper:

What does DragDropHelper bring to the table:

What does DragDropHelper NOT bring to the table:

Thanks for reviewing!

rastislavvasko commented 8 years ago

Great refactoring! 👏 Couldn't find any issues, LGTM. 👍