Fixes an issue that @engfragui brought up before in the context of their use of Reactist TextArea in the adaptive cards components. The issue then was resolved differently, due to certain circumstances with adaptive cards. But the issue remained. Now it appears again, and it's blocking me from merging https://github.com/Doist/todoist-web/pull/4988.
So here's the fix.
What's the problem and the fix
The text area is incompatible with horizontal resizing alongside us wanting it to stretch horizontally, which is what we want most of the time. This very text area in GitHub where I'm typing this has the same problem. So the fix was to add width: 100%; resize: vertical; to the <textarea /> element of the <TextArea /> component. Everything else in the diff is not about the fix, but a refactor of the CSS modules class name and adding a missing value in storybooks.
PR Checklist
[ ] Added tests for bugs / new features
[ ] Updated docs (storybooks, readme)
[x] Executed npm run validate and made sure no errors / warnings were shown
[x] Described changes in CHANGELOG.md
[ ] Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
[ ] Updated all static build artifacts (npm run build-all)
Short description
Fixes an issue that @engfragui brought up before in the context of their use of Reactist TextArea in the adaptive cards components. The issue then was resolved differently, due to certain circumstances with adaptive cards. But the issue remained. Now it appears again, and it's blocking me from merging https://github.com/Doist/todoist-web/pull/4988.
So here's the fix.
What's the problem and the fix
The text area is incompatible with horizontal resizing alongside us wanting it to stretch horizontally, which is what we want most of the time. This very text area in GitHub where I'm typing this has the same problem. So the fix was to add
width: 100%; resize: vertical;
to the<textarea />
element of the<TextArea />
component. Everything else in the diff is not about the fix, but a refactor of the CSS modules class name and adding a missing value in storybooks.PR Checklist
npm run validate
and made sure no errors / warnings were shownCHANGELOG.md
package.json
andpackage-lock.json
(npm --no-git-tag-version version <major|minor|patch>
) refnpm run build-all
)Versioning
A patch release is enough.