Doist / reactist

Open source React components made with ❤️ by Doist
http://doist.github.io/reactist
MIT License
249 stars 22 forks source link

feat: Allow defining a custom class on the Modal's overlay #718

Closed pauloslund closed 1 year ago

pauloslund commented 1 year ago

Short description

We need a way for consumers to define custom classes on the new Modal's overlay. This is needed to support custom styling for the overlay (eg. both the command menu, and quick add modal in Todoist), and for adding custom animations.

PR Checklist

Versioning

Patch

pauloslund commented 1 year ago

@gnapse Wanted to get your thoughts on this addition. I know generally we don't want to introduce exceptions to the design system, but I haven't been able to come up with an alternative approach that I liked. To clarify, some modals need to be able to restyle the included overlay. Generally this is by removing the background colour entirely, but they have also been adding classes to manage custom animations.