Doist / reactist

Open source React components made with ❤️ by Doist
http://doist.github.io/reactist
MIT License
251 stars 22 forks source link

Update Ariakit-utils to v0.17.0-next.23 or above to support React 17 #733

Closed frankieyan closed 1 year ago

frankieyan commented 1 year ago

🐛 Bug report

Current behavior

Using v17.7.0 in Twist will result in webpack emitting a warning:

image

This may be fixed by ariakit-utils@v0.17.0-next.23, specifically https://github.com/ariakit/ariakit/pull/1542. This will require Ariakit to be updated at least to ariakit@2.0.0-next.33. Note that next.32 has breaking changes to be aware of.

I'm not sure why the same warning isn't thrown in Todoist, which is also using React 17.0.2 and the checkbox field component.

Steps to reproduce the bug

Running Twist in dev mode results in a webpack fullscreen warning, which fails our Cypress tests

frankieyan commented 1 year ago

I had some issues updating to the latest ariakit@2.0.0-next.43 and ariakit-utils@0.17.0-next.27 (with ariakit-react-utils@0.17.0-next.27 added).