Doist / reactist

Open source React components made with ❤️ by Doist
http://doist.github.io/reactist
MIT License
248 stars 22 forks source link

feat: New Banner component #750

Closed engfragui closed 1 year ago

engfragui commented 1 year ago

Fixes https://github.com/Doist/Issues/issues/9215

Short description

New Banner component! 🎉

https://user-images.githubusercontent.com/1509326/214834007-542e1905-8631-4faf-8c25-5ae03037afeb.mp4


Note: in this piece of code you can see the current implementation of this type of banners that we're already using in production.

Our new Reactist banner component needs to be equivalent (or very close) so that we can use in todoist-web instead of the current custom implementation.

Reference

PR Checklist

Versioning

New feature (MINOR bump: v19.0.1 -> v19.1.0)

engfragui commented 1 year ago

Looking at https://github.com/Doist/todoist-web/pull/5846 (whose design is from this design mock) it seems like we might need/want to add some sort of "subtle" tone as well to our Banner (no background, gray button).

Happy to do this as a follow-up PR, possibly after getting feedback/confirmation from the Design team (https://www.figma.com/file/ypFhMfTimwHRViD9zAZhAD?node-id=67:197199#355231551).

engfragui commented 1 year ago

Status update on this PR: I'm mostly just trying to get the final requirements from Design team (see this comment https://www.figma.com/file/LYlWNzvhMDh907l07mPPQk?node-id=8321:272616#353688502)