chore: Very minor fixes to template component

Doist / reactist

Open source React components made with ❤️ by Doist

http://doist.github.io/reactist

MIT License

248 stars 22 forks source link

chore: Very minor fixes to template component #751

Closed engfragui closed 1 year ago

engfragui commented 1 year ago

Short description

Minor (stylistic) fixes to the template component that's generated via the templating command (via plop):

npm run plop component

PR Checklist

[ ] Added tests for bugs / new features
[ ] Updated docs (storybooks, readme)
[ ] Executed npm run validate and made sure no errors / warnings were shown
[ ] Described changes in CHANGELOG.md
[ ] Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
[ ] Updated all static build artifacts (npm run build-all)

Versioning

Not needed.

engfragui commented 1 year ago

@gnapse If there's any config to be set for new components re: Chromatic visual regression tests, I can stick it in this PR too (i.e. if there's a setting to be added somewhere).

gnapse commented 1 year ago

If there's any config to be set for new components re: Chromatic visual regression tests, I can stick it in this PR too (i.e. if there's a setting to be added somewhere).

Good idea. Though I'm hesitant to make it the default. Maybe you can add the chromatic setting in the story configs, but commented out. As in:

StoryComponent.parameters = {
    // Enable this or remove it (visual regression tests via chromatic.com)
    // chromatic: { disableSnapshot: false },
}

I intend to document a bit more about Chromatic in the future, and we will probably have a link to put here as well. But for now that will do.