Closed engfragui closed 1 year ago
We should be able to see this very clearly via our visual regression tests
Errr not true (see this build -- you can see that there's no side by side comparison of all the badges). Looking into it now š
Edit: I think the
{PlaygroundTemplate.bind({})}
inside the main storybook demo prevents the tests from working correctly š¤
@engfragui upon inspecting the Chromatic snapshots:
I find it odd that in there the vertical padding looks almost non-existent. Could it be that 1px is too little?
Could it be that 1px is too little?
@gnapse Errr the Figma mocks say the padding should be 3px š
I think it still looked good because the background was anyway expanding vertically to fill the entire vertical height, so we never noticed this. I will change to 3px.
Short description
This PR tweaks our (existing) Badge component:
Content of the Badge is now bold (as per this request on Twist). We should be able to see this very clearly via our visual regression tests, but here's some screenshots:
The appropriate line-height is enforced. No line-height set was causing the background of the badge to expand vertically when inside flex containers:
Although this can be easily set in the client, I figured we would want to enforce this in Reactist once and for all.
I'm also taking this chance to fix a couple of typos in the Banner stories (25 instead of 24 px -- I was probably drunk, who knows š¤·āāļø).
PR Checklist
npm run validate
and made sure no errors / warnings were shownCHANGELOG.md
package.json
andpackage-lock.json
(npm --no-git-tag-version version <major|minor|patch>
) refnpm run build-all
)Versioning
I think this is a minor fix, so I'm just bumping the patch.