fix: Tweak badge height as per design mocks

engfragui commented 1 year ago

Short description

Minor follow-up to https://github.com/Doist/reactist/pull/755, after testing the new version in todoist-web. Looks like this:

which looks too tall.

However, what we know is that:

font size should be (and is) 10px
height of the badge should be 15px (as per mocks)

Therefore the padding should be 2.5px at the top and 2.5px at the bottom. I had 3px and 3px before this change. Apologies, I hadn't checked the mock carefully enough apparently.

PR Checklist

[ ] Added tests for bugs / new features
[ ] Updated docs (storybooks, readme)
[x] Executed npm run validate and made sure no errors / warnings were shown
[x] Described changes in CHANGELOG.md
[x] Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
[x] Updated all static build artifacts (npm run build-all)
[x] Reviewed and approved Chromatic visual regression tests in CI

Versioning

Patch bump.

engfragui commented 1 year ago

@gnapse I'm running into an issue in the "Publish to Chromatic" build:

Error: error:0308010C:digital envelope routines::unsupported

Based on "the internet", it seems like this is due to fact that that build is running on Node v18, even though I don't think we're actually intentionally supporting it in Reactist.

Have you encountered this before? I feel like a possible solution could be to ensure that we're using node v16 in the chromatic configs 👀 Looking now.

Edit: Errr actually not sure this is popping up now. I don't think we updated any dependencies recently... 🤔

Edit: It actually started failing even before this PR, when I merged my previous PR. See: https://github.com/Doist/reactist/actions/runs/4224761740/jobs/7336138735

The PR that caused that build failure was https://github.com/Doist/reactist/pull/755

It's possible that the output is confusing and this is just an issue with my storybook stories since the output also says:

    → Running command: npm run --silent build:storybook -- --output-dir /tmp/chromatic--1693-GA2nfUaC9H7x --webpack-stats-json /tmp/chromatic--1693-GA2nfUaC9H7x
    → [*                   ]
The CLI tried to run your build:storybook script, but the command failed. This indicates a problem with your Storybook. Here's what to do:

Edit: Running

npm run build:storybook

locally works fine (no errors). 🤷‍♀️

engfragui commented 1 year ago

Fix for the Chromatic build is in https://github.com/Doist/reactist/pull/758

Doist / reactist