Closed henningmu closed 1 year ago
Can you please elaborate the problem and also provide the path to the files in which we can work upon?
What more information apart from the screenshots and the initial issue description do you need to work on this? :)
The file is here: https://github.com/Doist/reactist/blob/main/src/tabs/tabs.tsx – my gut feeling tells me, it's the space = 'xsmall',
in the TabsList
that we need to remove, but would need confirmation 👍
Is this issue still open?
It is still open @MahirMahdi.
@gnapse Can I work on it? @henningmu is right, removing space = 'xsmall'
removes unnecessary gap.
By default( with space = 'xsmall'
):
After removing space = 'xsmall'
:
@MahirMahdi yes, please feel free to submit a PR 👍
@henningmu Thanks. On it.
Description
There is an unnecessary gap between tabs in the Tab component. It seems like a
4px reactist xsmall gap
. We don't need that.Expected behaviour
Remove the gap between tabs for a more comfortable usage between them. For example in Twist's Inbox.
What needs to change
## ScreenshotsBefore![image](https://user-images.githubusercontent.com/7838670/226940440-c1b9912a-1930-4513-b618-965d4e1bd6fd.png)
After![image](https://user-images.githubusercontent.com/7838670/226940541-1b8bf146-82d3-4a1b-a7ab-d445a87a2443.png)