Doist / reactist

Open source React components made with ❤️ by Doist
http://doist.github.io/reactist
MIT License
248 stars 22 forks source link

chore: Upgrade to @ariakit/react v0.3.14 #778

Closed gnapse closed 7 months ago

gnapse commented 1 year ago

Short description

Upgrades to the latest Ariakit. Ariakit underwent a relatively major API change, a breaking change. However, given how we encapsulate their API within ours, I suspect that it is not a breaking change for us (to be determined).

PR Checklist

Versioning

We're releasing this as a beta version, so that we can dip our toes into upgrading in the apps. The apps not only use Reactist, but in many cases use other Ariakit components directly. So when upgrading the apps to the new Reactist version, we need to also upgrade the apps to use the new Ariakit version directly.

frankieyan commented 1 year ago

@gnapse my weekly bug requires the Ariakit upgrade here, should I take over this PR from you?

gnapse commented 10 months ago

@Bloomca I've noticed that you have work that depends on this. Let me know if you need help, as I should've been on top of this before, instead of neglecting it for some time. I can consider resuming the work here myself.

Bloomca commented 7 months ago

Sorry I made several releases due to another library depending on the Reactist, but I haven't realized it depends on ^22.0.0, and not just any 22 version.