Doist / reactist

Open source React components made with ❤️ by Doist
http://doist.github.io/reactist
MIT License
247 stars 21 forks source link

feat: Expose input border colours as --reactist-inputs-* variables #790

Closed frankieyan closed 1 year ago

frankieyan commented 1 year ago

Short description

This separates the CSS variables used for dividers and graphical elements' borders, from those used for input fields' borders.

To document these variables in Storybook, the four field-based components have had their documentation converted to MDX:

image

By having this separation, we'd be able to take advantage of the new inputs colours from Design (ref).

PR Checklist

Versioning

Minor. It's a bit of a grey area as the new variables are instantiated with the old --reactist-divider colours, keeping backwards compatibility, and existing overrides using these variables should not break.

frankieyan commented 1 year ago

@Bloomca I am wondering if I should stick with the old story names (i.e. ending in "Story") so that Chromatic can match up the diffs, or leave it as is and accept the new diffs. Thoughts? cc. @gnapse

Before After
image image
gnapse commented 1 year ago

I am wondering if I should stick with the old story names (i.e. ending in "Story") so that Chromatic can match up the diffs, or leave it as is and accept the new diffs. Thoughts?

We should not keep a name only because of Chromatic. If we really find the name change to be what we want, we should do the change, even if inconvenient.

I do agree the name change is for the better.