Closed engfragui closed 1 year ago
Whoops, it seems like my fix doesn't actually do anything when testing in Reactist Storybook https://doist.github.io/reactist/?path=/docs/components-input--input-story
I was apparently meant to concat window.location.origin
with window.location.pathname
😅
although I'm not sure it will actually do what I want it to do, consistently.
Either way, I will investigate and follow-up on this in https://github.com/Doist/reactist/pull/795
Short description
While browsing a couple of Reactist storybook stories, I've noticed that there are some broken links that don't include the path "reactist":
https://github.com/Doist/reactist/assets/1509326/26b1d8cf-3c44-41c7-97aa-b26bcb4fa96e
This PR should fix those links so that do include the correct path and therefore lead the viewer to the right place. (I cannot actually test what will actually happen when this gets deployed to https://doist.github.io/reactist/, as the storybook dev version deployed via Chromatic (linked in the builds below) does not actually include the custom "/reactist/" path in the URL 🤷♀️ Either way, this won't break things more than they are now.
PR Checklist
npm run validate
and made sure no errors / warnings were shownCHANGELOG.md
package.json
andpackage-lock.json
(npm --no-git-tag-version version <major|minor|patch>
) refVersioning
Bumped patch. This is just a doc change.