Closed pedroalves0 closed 10 months ago
I'm aware that Twist still uses it @rfgamaral , but given that development on Twist is somewhat stalled, I think it's a fair compromise that we'll move on with modernizing Reactist. Given your pushback, let's expand the discussion to the team; I'll create a thread.
Given your pushback, let's expand the discussion to the team; I'll create a thread.
It's not a pushback per se, I'm just concerned that when Twist development resumes, we'll have a harder time doing so, because we might need to upgrade Reactist to the latest version for small changes/improvements, but won't be able to without first dealing with the removal DeprecatedModal
that is being heavily used by it.
I think it's a fair compromise that we'll move on with modernizing Reactist.
Maybe you're right, but I just wanted to bring that to our attention.
Update here, our internal discussion concluded that the effort to migrate the deprecated modals on Twist is relatively small. Thus, I'm going ahead with the merge of this PR.
Short description
The
DeprecatedModal
component is built on top of the@reach/dialog
module, which is no longer maintained and lacks support for react v18. When installing Reactist in a project using the latest React version, similar warnings to the following are thrown:As the component has been marked for deprecated for a long time now, it's reasonable to assume that it can be removed (alongside
@reach/dialog
) without major impact to consumers.PR Checklist
npm run validate
and made sure no errors / warnings were shownCHANGELOG.md
package.json
andpackage-lock.json
(npm --no-git-tag-version version <major|minor|patch>
) refVersioning
Major version bump to v22.0.0, as the removal of an exported component is a breaking change.