Doist / reactist

Open source React components made with ❤️ by Doist
http://doist.github.io/reactist
MIT License
247 stars 21 forks source link

fix: Vertical alignment of inline code inside a `Prose` component #811

Closed gnapse closed 7 months ago

gnapse commented 7 months ago

Short description

Removes the vertical-align: text-top style from inline code elements inside a Prose component.

Long description

The style vertical-align top is not needed. It causes an almost imperceptible misalignment in most browsers:

Screen recording

![CleanShot 2024-01-05 at 12 41 41](https://github.com/Doist/reactist/assets/15199/c62e125b-2705-413f-b363-c86ef3fdda35)

But what's worse, in some situation (e.g. a certain Firefox version in Linux, or perhaps any Firefox in Linux), it does this, which is much more extreme:

Screenshot

![image](https://github.com/Doist/reactist/assets/15199/995b902e-98c4-4d69-bbee-e095e9ffe5c7)

PR Checklist

Versioning

Patch release