fix: More fixes related to the Ariakit upgrade

Doist / reactist

Open source React components made with ❤️ by Doist

http://doist.github.io/reactist

MIT License

247 stars 21 forks source link

fix: More fixes related to the Ariakit upgrade #818

Closed gnapse closed 5 months ago

gnapse commented 5 months ago

Short description

Last issues needed to be fixed for the Ariakit upgrade.

[Fix] Reset anchor rect after context menu is closed.
[Fix] Revert earlier attempt to auto-close menus when they lose focus.

PR Checklist

[ ] Added tests for bugs / new features
[ ] Updated docs (storybooks, readme)
[x] Executed npm run validate and made sure no errors / warnings were shown
[x] Described changes in CHANGELOG.md
[x] Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
[ ] Reviewed and approved Chromatic visual regression tests in CI

gnapse commented 5 months ago

the fix was removed in https://github.com/Doist/reactist/pull/778

Ooops, I'm not sure why and do not fully recall now. Possibly a mishap, given how it is needed now.

gnapse commented 5 months ago

FYI, I added another commit. It undoes something that was done in #817 to fix an issue, but in turns out that that change introduced another issue. Plus, I was able to overcome the original issue with changes in todoist-web code itself, not needing the fix in this library.

gnapse commented 5 months ago

@rfgamaral you requested information about the fix to the issue of the scheduler and other nested dropdowns not opening properly in the task menu. Here's the explanation:

I debugged it by focusing in all the ways in which the menu can be dismissed, which can only happen if the store.hide() function of the menu’s Ariakit store is called. By placing breakpoints on each of the points in the code that call it, I found the culprit, which turned out to be one I added last week to fix another issue. But that other issue could be fixed differently, thus what I had added last week could be removed, and it fixed this particular issue. More details in this commit from this PR.

rfgamaral commented 5 months ago

Thank you, @gnapse, that helped 👍